Skip to content

Commit

Permalink
feat: set webhook secretName, delete ValidatingWebhookConfiguration a…
Browse files Browse the repository at this point in the history
…nnotations
  • Loading branch information
erichchen authored and rocpyang committed Jun 20, 2024
1 parent a842a37 commit 59fb216
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions incubator/opentelemetry-operator/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: tencent-opentelemetry-operator
version: 0.86.0
version: 0.87.0
description: OpenTelemetry Operator Helm chart for Kubernetes
type: application
home: https://opentelemetry.io/
Expand All @@ -9,5 +9,5 @@ sources:
maintainers:
- name: erichchen
icon: https://cloudcache.tencent-cloud.com/qcloud/ui/static/Industry_tke/80444e53-c142-4896-bc8a-ef4ecf75c682.png
appVersion: 0.86.0
appVersion: 0.87.0
kubeVersion: '>= 1.19.0-0'
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,6 @@ webhooks:
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
annotations:
cert-manager.io/inject-ca-from: {{ printf "%s/%s-serving-cert" .Release.Namespace (include "opentelemetry-operator.fullname" .) }}
labels:
{{- include "opentelemetry-operator.labels" . | nindent 4 }}
app.kubernetes.io/component: webhook
Expand Down
2 changes: 1 addition & 1 deletion incubator/opentelemetry-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ kubeRBACProxy:
admissionWebhooks:
create: true
failurePolicy: Fail
secretName: ""
secretName: "tencent-opentelemetry-operator-webhook-service-cert"

## Defines the sidecar injection logic in Pods.
## - Ignore, the injection is fail-open. The pod will be created, but the sidecar won't be injected.
Expand Down

0 comments on commit 59fb216

Please sign in to comment.