ssd1306: Displayer interface improvements #665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay has Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
|
Does this display support any other pixel formats than the one monochrome pixel format? |
aykevl
reviewed
Mar 4, 2024
Comment on lines
+285
to
+295
| d.Command(COLUMNADDR) | ||
| d.Command(d.resetCol[0] + uint8(x)) | ||
| d.Command(d.resetCol[0] + uint8(x) + uint8(w) - 1) | ||
|
|
||
| // TODO: handle when the bitmap is not aligned to 8 vertical pixels | ||
| d.Command(PAGEADDR) | ||
| d.Command((d.resetPage[0] + uint8(y)) / 8) | ||
| d.Command((d.resetPage[0] + uint8(y) + uint8(h)) / 8) | ||
|
|
||
| d.Tx(bitmap.RawBuffer(), false) | ||
| return nil |
There was a problem hiding this comment.
For a prototype it may be easier to go through the bitmap and set it manually:
width, height := bitmap.Size()
for by := 0; by < height; by++ {
for bx := 0; bx < width; bx++ {
d.SetPixel(x+bx, y+by, bitmap.Get(bx, by).RGBA())
}
}It'll be slower than necessary but it has a good chance of actually working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement the pixel package based interface for the SSD1306 display.