This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
check for enabled backup after sourcing environment #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
What's missing for merge? |
|
I was waiting on a potential review from the o11y team. Thanks for contributing! |
Merged
mathisve
added a commit
to mathisve/ts-helm-charts
that referenced
this pull request
Mar 27, 2023
check for enabled backup after sourcing environment
mathisve
added a commit
to mathisve/ts-helm-charts
that referenced
this pull request
Mar 28, 2023
check for enabled backup after sourcing environment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Recently, some heavy refactoring in the backup/restore procedure took place. This also changed the way how the environment variables etc were set up for the statefulset.
With more recent helm chart versions, it is not possible anymore to restore a replica node from pgbackrest due to checking too early in script if backups are enabled or not.
Furthermore, slaves are not able to fetch WAL from archive, leading to broken replicas (master already disposed WAL segment).
I ended up with a degraded cluster multiple times in the last weeks. This seems to fix it for me.
Which issue this PR fixes
Checklist