refactor: histogram #293
refactor: histogram #293
Conversation
I just implmented generic version of some types in `histogram.rs`.The problem of loss of precision needs to be solved, perhaps make accurate to milliseconds when calling `observe` function.
|
I just implemented generic version of some types in @breeswish |
src/histogram.rs
Outdated
| @@ -397,21 +408,29 @@ impl HistogramTimer { | |||
| let v = duration_to_seconds(self.start.elapsed()); | |||
There was a problem hiding this comment.
Accurate to milliseconds should fix this, is it OK to do so? @breeswish
src/histogram.rs
Outdated
| @@ -397,21 +408,29 @@ impl HistogramTimer { | |||
| let v = duration_to_seconds(self.start.elapsed()); | |||
| self.observed = true; | |||
| if record { | |||
| self.histogram.observe(v); | |||
| // FIXME: 精度丢失 | |||
There was a problem hiding this comment.
don't use Chinese comments
- make `DEFAULT_BUCKETS` accurate to milliseconds - and adapted to relevant test cases
src/histogram.rs
Outdated
| core: Arc<HistogramCore<S, C>>, | ||
| } | ||
|
|
||
| /// /// A [`Metric`](::core::Metric) counts individual observations from an event or sample stream in |
src/histogram.rs
Outdated
| @@ -397,21 +408,29 @@ impl HistogramTimer { | |||
| let v = duration_to_seconds(self.start.elapsed()); | |||
| self.observed = true; | |||
| if record { | |||
| self.histogram.observe(v); | |||
| // FIXME: 精度丢失 | |||
also fix duplicated `///` mark
|
@chux0519 Thanks for the PR! Looks like your PR makes a breaking change that previously |
you are right, I will definitely fix this |
|
@chux0519 are you planning to continue the work on this pull request? If not, I would close here. |
Sorry, I may not be able to continue this PR, it can be closed |
Open the PR.
Still have problem to be solved.
See the FIXME part in code