Refine CI, use travis windows #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ana Hobden <[email protected]>
|
Note that the entire build now takes 16 minutes. The Windows machine on Travis takes 10 minutes to run (compared with 1 minute on AppVeyor) because Travis uses rustup and we've got the bug rust-lang/rustup#1540. |
|
I noticed this as well. :( |
|
I know @nrc was working on the upstream rustup bug at one point. Maybe this is something one of us should go fix. It's been one of the biggest rustup issues and it's not all that hard to fix somehow. |
I even have a PR, just needs some tests and some fixups. I guess this is motivation to get the damn thing finished |
|
Aren't 9 CI checks too much for such a simple crate? |
Signed-off-by: Ana Hobden <[email protected]>
BusyJay
reviewed
Jun 13, 2019
BusyJay
reviewed
Jun 14, 2019
.travis.yml
Outdated
|
|
||
| script: | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
A bad merge! Sorry :(
BusyJay
approved these changes
Jun 17, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopts using the Travis CI windows boxes for CI. Adopts a nearly identical CI to tikv/raft-rs#190.
AAppveyor failure is expected and shouldn't prevent merge. We can turn off appveyor after.