Support complex backend/frontend hierarchies #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Previously the seL4 cross-connector had the BARs swapped so that the dataport would be the first mapping (at offset 0), but turned out patching QEMU to have the offset option is not a big job. This saves us from pushing an API-breaking change to seL4 source trees. Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Markku Ahvenjärvi <[email protected]>
Signed-off-by: Markku Ahvenjärvi <[email protected]>
Signed-off-by: Markku Ahvenjärvi <[email protected]>
This change aligns the memory size with VM1 ram_size. Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Markku Ahvenjärvi <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
hlyytine
force-pushed
the
complex
branch
3 times, most recently
from
a851df1 to
a4f2d1b
Compare
elmankku
requested changes
Oct 25, 2023
| s->ioreq_buffer = mmap(NULL, sizeof(*s->ioreq_buffer), | ||
| PROT_READ | PROT_WRITE, MAP_SHARED, s->ioreqfd, 0); | ||
| if (!s->ioreq_buffer) { | ||
| s->iobuf = mmap(NULL, 2 * 4096, PROT_READ | PROT_WRITE, MAP_SHARED, |
There was a problem hiding this comment.
The size could be in the kernel header. Then these will be in sync.
| { | ||
| PCIDevice *dev = pci_devs[ioreq->addr_space]; | ||
| PCIDevice *dev = pci_devs[addr_space]; |
There was a problem hiding this comment.
Would the pci_dev be a more appropriate name? Just thinking
|
|
||
| msg->mr0 = BIT_FIELD_SET(msg->mr0, RPC_MR0_STATE, RPC_MR0_STATE_COMPLETE); | ||
|
|
||
| /* smp_wmb()? */ |
There was a problem hiding this comment.
Yes, a write barrier would be appropriate here because it ensures mr0 is flushed before andvance
| uint32_t *event_bar = cookie; | ||
|
|
||
| /* data does not matter, just the write fault */ | ||
| event_bar[0] = 1; |
There was a problem hiding this comment.
A write barrier (or write release) after this would be good to ensure ordering of writes
| goto err; | ||
| } | ||
| s->event_bar_fd = rc; | ||
| s->event_bar = mmap(NULL, 4096, PROT_READ | PROT_WRITE, MAP_SHARED, |
There was a problem hiding this comment.
The size could be defined in the kernel header
| munmap(s->event_bar, 4096); | ||
|
|
||
| if (s->iobuf) | ||
| munmap(s->iobuf, 2 * 4096); | ||
|
|
| if (rc) | ||
| continue; | ||
|
|
||
| handle_ioreq(s); | ||
| while ((msg = rpcmsg_queue_head(s->rpc.rx_queue)) != NULL) { | ||
| seL4_Word state = BIT_FIELD_GET(msg->mr0, RPC_MR0_STATE); |
There was a problem hiding this comment.
Load acquire here would (or read barrier before) would be appropriate here
| @@ -23,6 +23,8 @@ | |||
| #include <sys/ioctl.h> | |||
| #include <sel4/sel4_virt.h> | |||
|
|
|||
| #define EVENT_BAR_EMIT_REGISTER 0x0 | |||
There was a problem hiding this comment.
I wonder if this should be placed in the kernel header?
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Signed-off-by: Hannu Lyytinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.