mavlink: Use polling fd, hack to prevent crash #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a draft, maybe help for further debugging. |
joukkone
force-pushed
the
mavlink_fix_totest
branch
from
9858102 to
31f6e41
Compare
Poling fd is used to detect if uart hangs and set _uart_fd to -1. Set instance pointer to zero so stop command cannot delete Mavlink instance. That hack prevents crash in kernel mode when usb-cable is removed and then inserted to restore connection. Root cause for memory corruption remains unclear. Signed-off-by: Jouni Ukkonen <[email protected]>
joukkone
force-pushed
the
mavlink_fix_totest
branch
from
31f6e41 to
8a2a9b1
Compare
|
The root cause is fixed in #866, this one can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poling fd is used to detect if uart hangs and
set _uart_fd to -1. Set instance pointer to
zero so stop command cannot delete Mavlink instance. That hack prevents crash in kernel mode when usb-cable is removed and then inserted to restore connection. Root cause for memory corruption remains unclear.
Solved Problem
When ... I found that ...
Fixes #{Github issue ID}
Solution
Changelog Entry
For release notes:
Alternatives
We could also ...
Test coverage
Context
Related links, screenshot before/after, video