Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board_reset.cpp: Hartid must be read with local interrupts disabled #845

Merged
merged 1 commit into from
Dec 17, 2024
Merged

board_reset.cpp: Hartid must be read with local interrupts disabled #845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion platforms/nuttx/src/px4/microchip/mpfs/board_reset/board_reset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,16 @@ static void board_reset_enter_bootloader_and_continue_boot()

static int board_reset_enter_app(FAR void *arg)
{
uintptr_t hartid = riscv_mhartid();
uintptr_t hartid;

/* Mask local interrupts */

up_irq_save();

/* It is now safe to read and hold hartid locally (CPU cannot change) */

hartid = riscv_mhartid();

#ifdef CONFIG_SMP
/* Notify that this CPU is paused */

Expand Down
Loading