Remove venv, migrate checks to flake check #7
Conversation
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
| # pycodestyle | ||
| pycodestyle = | ||
| pkgs.runCommandLocal "pycodestyle" { | ||
| nativeBuildInputs = [pkgs.python3.pkgs.pycodestyle]; | ||
| } '' | ||
| cd ${../.} | ||
| pycodestyle --max-line-length 90 $(find . -name "*.py" ! -path "*venv*" ! -path "*eggs*") | ||
| touch $out | ||
| ''; | ||
| # pylint | ||
| pylint = | ||
| pkgs.runCommandLocal "pylint" { | ||
| nativeBuildInputs = with pkgs.python3Packages; [colorlog gitpython pandas pylint pytest tabulate]; | ||
| } '' | ||
| cd ${../.} | ||
| pylint --disable duplicate-code -rn $(find . -name "*.py" ! -path "*venv*" ! -path "*eggs*") | ||
| touch $out | ||
| ''; |
There was a problem hiding this comment.
We might be able to run these with treefmt. I think it can be configured to run arbitrary commands. Failing that, I might have a look at adding support directly for pycodestyle and pylint.
There was a problem hiding this comment.
@brianmcgee : thanks for you comment. The changes in this PR are based on Florian's changes in: https://github.com/tiiuae/sbomnix/pull/94/files#diff-49f7a3ba809188883d2a60aef5bcd93529587f91ebb40004b7fc3f412feae79cR22-R38.
I propose we would merge this now, and then do another round of changes (to other repositories too) to move them to treefmt if it turns out it's easily doable.
There was a problem hiding this comment.
100%, I was suggesting it as a follow up, sorry for not making that clearer
venvusage and the unnecessary pip install run whenever the shell is entered. With this change, we can remove all Makefile targets and scripts related to managing that. This change is similar to the change done in: bring in python devshell with Nix sbomnix#94 (comment)nix flake check: black, pycodestyle, pylint.licensefiles