REST: Correct/clarify built-in-endpoints dependencies/behavior (3.10, others) #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates in Health check endpoint
victorleeTG
requested changes
Sep 18, 2024
| @@ -32,6 +32,8 @@ These endpoints are simple diagnostic utilities, which respond with the followin | |||
|
|
|||
| .GET /echo Request and Response | |||
|
|
|||
| Note: 9000 port is for RESTPP server then in the below request it should not return message "Hello GSQL" , do we need to correct this? | |||
There was a problem hiding this comment.
You wrote an internal comment and question, not a proposed change.
Your comment is not clear: I don't know what you mean by "should" in "it should not return message 'Hello GSQL'."
Comment on lines
+64
to
+66
| - This 'api/ping endpoint is depended on GUI service and it cannot run on the higher number of nodes than 3 based on https://github.com/tigergraph/cqrs/blob/900a0fb81a649adbb2d60884b2e5ad23bb43b2f1/tutopia/common/config/node_assignment.go#L16. Therefor, hitting this endpoint on those nodes > 3 shows 502 error. So, this should not be treated as "health check endpoint" which is confusing our customers: https://tigergraph.zendesk.com/agent/tickets/53725. | ||
| Zulip thread: https://zulip.graphtiger.com/#narrow/stream/39-TigerGraph-Frontline/topic/.2353725.3A.20.5BGoldman.20Sachs-US.5D.20-.20Need.20help.20to.20setup.20the.20paral.2E.2E.2E | ||
|
|
There was a problem hiding this comment.
This again is an internal technical discussion. It seems there is some concern about the usefulness or reliability of the /api/ping endpoint. Please discuss internally to agree on under what conditions a user can safety use this endpoint and describe those conditions.
victorleeTG
changed the title
victorleeTG
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates in Health check endpoint