-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gml 1660 support jwt token auth in py tiger graph #224
Changes from 13 commits
e3aac00
5537745
b584eb2
b12759c
030656c
80f0503
ce0d746
3fef8fc
1ad4209
1cf1615
e7eaaaa
4f3537f
dea665f
6fabbc5
0d20920
34f05cb
185d1d4
3476060
163236a
5bc4f3e
089165b
c55cca4
eebf27e
3403e3c
f5ec141
e69505b
39bca3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ def make_connection(graphname: str = None): | |
"sslPort": "443", | ||
"tgCloud": False, | ||
"gcp": False, | ||
"jwtToken": "" | ||
} | ||
|
||
path = os.path.dirname(os.path.realpath(__file__)) | ||
|
@@ -42,6 +43,7 @@ def make_connection(graphname: str = None): | |
certPath=server_config["certPath"], | ||
sslPort=server_config["sslPort"], | ||
gcp=server_config["gcp"], | ||
jwtToken=server_config["jwtToken"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we support this in our current testing pipeline? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, we need to modify the config file to add the jwtToken field but set it to empty str to avoid actually using it now. Meanwhile, we need to figure out with QE team how to config the DB to use jwtToken There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just double check here: does server_config contains this key "jwtToken"? I don't see the config file modified. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure. I just add the jwtToken to the config file and set it to empty.
|
||
) | ||
if server_config.get("getToken", False): | ||
conn.getToken(conn.createSecret()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is jwtToken also used when authMode is pwd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently no, still use pwd. in the init, if the db doesn't support jwt, it will raise an error asking users to use username and password.