-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2118 feat(tgcloud4): Cloud v4 Docs; #68
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 7e95b19.
✅ Deploy Preview for docs-tigergraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
frame-src add mailto
#url: /Users/victorlee/Documents/GitHub1/Docs/antora-ui/build/ui-bundle.zip?raw=true | ||
snapshot: true | ||
asciidoc: | ||
attributes: | ||
page-component-order: '!home, tigergraph-server, gsql-ref, cloud, cloudbeta, cloudBeta, gui, insights, graph-ml, pytigergraph, ml-workbench, graphql, tg-copilot' | ||
page-component-order: '!home, tigergraph-server, gsql-ref, cloud4, gui, insights, graph-ml, pytigergraph, ml-workbench, graphql, tg-copilot, cloud' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samzhou2 I would not put the legacy cloud at the end. I think you should group the two versions of cloud together. Instead, I would change the title property of the original cloud from "TigerGraph Cloud" to "TigerGraph Cloud 3 (Classic)" or something like that.
I actually want some UI coding help to divide the menu into 3 parts:
- DB and GSQL (by far the most popular part of the documentation)
- Cloud
- Tools, both UI and Data Science
@@ -34,24 +34,24 @@ content: | |||
# What branch, main or some staging, e.g. cloud-dev? | |||
sources: | |||
- url: https://github.com/tigergraph/doc-site.git | |||
branches: [main] | |||
branches: [cloud-dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samzhou2 I can't let you push this into the main branch of doc-site. We never want to change this line in the production branch.
What you should do is get the https://cloud-dev--docs-tigergraph.netlify.app/home/ site fully polished, then when you want to publish to main, we can work on that together.
If you are based on a current version of antora-playbook.yml, then I maybe only 2 lines need to change:
- start_paths: [modules/cloud, modules/cloudbeta]
- age-component-order: '!home, tigergraph-server, gsql-ref, cloud, cloudbeta, cloudBeta, gui, insights, graph-ml, pytigergraph, ml-workbench, graphql, tg-copilot'
If you have antora-ui changes, rather than having the main doc-site point to your cloud-dev branch of antorai-ui, you should merge your antori-ui updates to main. Yes, you have to coordinate the merges of two different repos, and we have to be confident that it will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will not push this change, I leave it here in the PR was because maily want to have a preview site available, so that everyone else can review the docs at https://deploy-preview-68--docs-tigergraph.netlify.app/cloud4/main/overview/
home/modules/ROOT/pages/index.adoc
Outdated
==== | ||
* xref:3.11@tigergraph-server:release-notes:index.adoc[TigerGraph Server 3.11.0 Preview] was released on Oct 25, 2024. | ||
|
||
* xref:3.10@tigergraph-server:release-notes:index.adoc#_fixed_and_improved_in_3_10_2[TigerGraph Server 3.10.2] was released on Oct 18, 2024. | ||
|
||
* xref:4.1@tigergraph-server:release-notes:index.adoc[TigerGraph Server 4.1.0 Preview] was released on Aug. 30, 2024. | ||
|
||
* xref:cloudBeta:overview:index.adoc[TigerGraph Cloud 4.0 beta] was released on Apr. 29, 2024. | ||
* xref:cloud4:overview:index.adoc[TigerGraph Cloud 4] was released on Apr. 29, 2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samzhou2 You should not rewrite history.
TigerGraph Cloud 4.0 Beta WAS published on Apr 29, 2024. It was Beta in April.
Rather than changing history, you should announcement the new release of TG Cloud 4.1 (?)
We are moving all the historical items to the bottom of the page.
Currently, we have zero announcements at the top, but I think we can have one latest announcement at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added "beta" back, but we will need to change the URL since when we release cloud GA, beta docs will no longer available and should be removed. Added redirect rules for beta to direct to cloud4 overview page
branches: [main] | ||
start_paths: [modules/cloud, modules/cloudbeta] | ||
branches: [dev] | ||
start_paths: [modules/cloud, modules/cloud4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samzhou2 So I assume you doing a simple rename of the module cloud-docs/cloudbeta to cloud-docs/cloud4 and/or changing the name(?) property in the antora.yml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added redirects from cloudbeta to cloud4
No description provided.