fix(lane_change): cherry pick for improvements #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs(lane_change): update documentation Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * update validity check flow chart Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * explanation for the valid paths Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Add prerequisite in the requirement Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * update diagram Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Edit the parameters Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Explaining lane expansion Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix lane expansion document Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…tion#6561) * fix(lane_change): check prepare phase in intersection Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Add new parameter, also create function Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Rename parameters Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix spell check * fix config file Signed-off-by: Zulfaqar Azmi <[email protected]> * call the function check_prepare_phase only once Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * add parameter description in README Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * minor refactoring Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Doxygen description Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]>
…efoundation#6722) Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
changed the title
…ndation#6734) Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
shmpwk
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several lane change commits are added for improvement of the path generation and safety check.
fix(lane_change): cherry-pick for lane change improvement #820
Related links
✅docs(lane_change): update documentation #6544
✅fix(lane_change): check prepare phase in intersection #6561
✅fix(lane_change): fix terminal path not working in some case #6722
✅fix(lane_change): limit prepare and lane changing length #6734
Tests performed
Not applicable
Notes for reviewers
Not applicable
Interface changes
Not applicable
Effects on system behavior
Not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.