Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): remove missing params in hesai_*.launch.xml #382

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix(common): remove missing params in hesai_*.launch.xml #382

merged 1 commit into from
Jan 30, 2025

Conversation

Autumn60
Copy link
Contributor

Fixed problem of using parameters that were erased in #381

@Autumn60 Autumn60 requested a review from shmpwk January 30, 2025 11:46
shmpwk
shmpwk approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、、、目が節穴でした。。。

@shmpwk shmpwk merged commit e457bc3 into tier4/universe Jan 30, 2025
9 of 10 checks passed
@shmpwk shmpwk deleted the hotfix/common/remove_missing_param branch January 30, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmpwk shmpwk shmpwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Autumn60 @shmpwk