Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aip_x2_gen2_launch and aip_x2_gen2_description #367

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Jan 10, 2025

Description

最新の変更を追従できるように、X2 Gen2向けのaip_x2_gen2_launchaip_x2_gen2_descriptionをtier4/universeブランチにマージします。
これらのファイルはbeta/x2_gen2/v0.29.2からコピーしています。

Note

gen2向けのファイルを追加しているだけなので、他のプロダクトには影響ありません。

@TomohitoAndo TomohitoAndo changed the title feat: add aip_x2_gen2_launch and aip_x2_gen2_discription feat: add aip_x2_gen2_launch and aip_x2_gen2_description Jan 10, 2025
@TomohitoAndo TomohitoAndo marked this pull request as ready for review January 15, 2025 04:28
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


<exec_depend>common_sensor_launch</exec_depend>
<exec_depend>dummy_diag_publisher</exec_depend>
<exec_depend>gnss_poser</exec_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最新にマージするなら、このあたりautoware_ prefixをつける必要があるのでは…!

</node>

<!-- NavSatFix to MGRS Pose -->
<include file="$(find-pkg-share gnss_poser)/launch/gnss_poser.launch.xml">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このあたりもautoware_ が必要

@TomohitoAndo TomohitoAndo merged commit 38d4df3 into tier4/universe Jan 15, 2025
11 of 13 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/add-aip-x2-gen2 branch January 15, 2025 04:38
@TomohitoAndo
Copy link
Contributor Author

すみません、マージしてしまったので、修正PRを出します 🙏

@tkimura4
Copy link
Contributor

@TomohitoAndo
全部網羅できているかわからないですが、おそらく必要な変更下記のあたりです。よろしくおねがいします。

#257
#267
#273
#283
#319
#353

@TomohitoAndo
Copy link
Contributor Author

prefixを追加するPR

@shmpwk
Copy link
Contributor

shmpwk commented Jan 16, 2025

@TomohitoAndo
nebula_node_container.launch.py はcommon_sensor_launchではなく、X2独自のものを使っている背景はありますでしょうか?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants