-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify nebula_node_container.launch.py
to use nebula v0.2.1
#360
Conversation
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
nebula_node_container.launch.py
to use nebula v0.2.1
Could you review whether the changes in this pull request make sense? I think there are three main points.
|
Meeting Note : (@shmpwk , @SakodaShintaro ) TODO
その他メモ
|
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
extra_arguments=[ | ||
{"use_intra_process_comms": LaunchConfiguration("use_intra_process")} | ||
], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HwMonitorWrapper消えてないかも(名前から"Ros"は抜けた)
しかし読み込もうとしても上手くいかない
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
本家sample_sensor_kit_launchにおいてnebulaがv0.2.0になるときの修正PRにおいて削除されている
https://github.com/autowarefoundation/sample_sensor_kit_launch/pull/106/files
よってこちらでも削除することが正当だと思われる
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
安藤さんに確認したところ、 |
@TomohitoAndo |
Description
Currently, the Autonomous Driving Release Engineering (ADRE) team is working to make the versions of
autoware.repos
intier4/pilot-auto
match the versions of the one inautowarefoundation/autoware
.In particular,
autowarefoundation/autoware
uses nebula v0.2.1, https://github.com/autowarefoundation/autoware/blob/8f35d9b7deacf55363b19bc8118b93d729c719f5/autoware.repos#L88-L91but
tier4/pilot-auto
uses nebula v0.0.1. https://github.com/tier4/pilot-auto/blob/04e41d997a353ba910ba67e27beed10d42a236eb/autoware.repos#L95-L98This pull request introduces some changes of
nebula_node_container.launch.py
to use nebula v0.2.1 in plot-auto.vanilla.https://github.com/tier4/nebula/releases/tag/v0.2.1
Test
By using
tier4/pilot-auto.vanilla:fix/follow_oss_autoware_versions
(PR : https://github.com/tier4/pilot-auto/pull/1068)planning_simulator
with sample_maplogging_simulator
with sample_rosbaglogging_simulator
with awsim_gt_data(TIER IV INTERNAL)e2e_simulator
with AWSIM v1.3.1