Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify nebula_node_container.launch.py to use nebula v0.2.1 #360

Merged
merged 12 commits into from
Jan 23, 2025

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Dec 20, 2024

Description

Currently, the Autonomous Driving Release Engineering (ADRE) team is working to make the versions of autoware.repos in tier4/pilot-auto match the versions of the one in autowarefoundation/autoware.

In particular, autowarefoundation/autoware uses nebula v0.2.1, https://github.com/autowarefoundation/autoware/blob/8f35d9b7deacf55363b19bc8118b93d729c719f5/autoware.repos#L88-L91

but tier4/pilot-auto uses nebula v0.0.1. https://github.com/tier4/pilot-auto/blob/04e41d997a353ba910ba67e27beed10d42a236eb/autoware.repos#L95-L98

This pull request introduces some changes of nebula_node_container.launch.py to use nebula v0.2.1 in plot-auto.vanilla.

https://github.com/tier4/nebula/releases/tag/v0.2.1

Test

By using tier4/pilot-auto.vanilla:fix/follow_oss_autoware_versions (PR : https://github.com/tier4/pilot-auto/pull/1068)

@SakodaShintaro SakodaShintaro self-assigned this Dec 20, 2024
@SakodaShintaro SakodaShintaro changed the title fix: fix nebula_node_container.launch.py to use nebula v0.2.1 fix: modify nebula_node_container.launch.py to use nebula v0.2.1 Dec 20, 2024
@SakodaShintaro SakodaShintaro marked this pull request as ready for review December 20, 2024 06:59
@shmpwk shmpwk requested review from amadeuszsz and vividf December 20, 2024 10:14
@SakodaShintaro
Copy link
Contributor Author

@amadeuszsz @vividf

Could you review whether the changes in this pull request make sense?

I think there are three main points.

  • Changes related to arguments
  • DriverRosWrapper -> RosWrapper
  • HwMonitorRosWrapper -> Removed

@SakodaShintaro
Copy link
Contributor Author

SakodaShintaro commented Jan 16, 2025

Meeting Note : (@shmpwk , @SakodaShintaro )

TODO

その他メモ

  • ipの設定などはHILSなどじゃないとわからない。ADREとしてはパケットからのlogging_simulatorが動いていれば十分とする
  • このPRは若林さんのレビューでapprove可

Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
extra_arguments=[
{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}
],
)
Copy link
Contributor Author

@SakodaShintaro SakodaShintaro Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/tier4/nebula/blob/v0.2.1/nebula_ros/include/nebula_ros/velodyne/hw_monitor_wrapper.hpp

HwMonitorWrapper消えてないかも(名前から"Ros"は抜けた)

しかし読み込もうとしても上手くいかない

Copy link
Contributor Author

@SakodaShintaro SakodaShintaro Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本家sample_sensor_kit_launchにおいてnebulaがv0.2.0になるときの修正PRにおいて削除されている
https://github.com/autowarefoundation/sample_sensor_kit_launch/pull/106/files

よってこちらでも削除することが正当だと思われる

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk
Copy link
Contributor

shmpwk commented Jan 22, 2025

X2Gen2がcommonを使うのではなく独自に nebula_node_container.launch.py を持っていることについて確認
https://github.com/tier4/aip_launcher/tree/tier4/universe/aip_x2_gen2_launch/launch

安藤さんに確認したところ、
X2はデフォルトのものがぱっと使えなかったので独自に編集したようです。
commonを使えるなら使いたいと仰っていました。
vanilla v0.41.0 -> X2 v4.1.0にsyncするまでに対応が必要そうですね

@SakodaShintaro SakodaShintaro merged commit 98b0689 into tier4/universe Jan 23, 2025
9 of 10 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/to_use_nebula_v0-2-1 branch January 23, 2025 04:17
@shmpwk
Copy link
Contributor

shmpwk commented Jan 23, 2025

@TomohitoAndo
口頭でお伝えしたように、X2ではnebula_node_container.launch.pyが別の場所にあるので、このPRのようなsyncが必要です。
もしくは、X2のファイルをこちらのcommonファイルに置き換えていただけたらと思います 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants