str_like case sensitivity

NEWS.md

@@ -1,4 +1,5 @@
 # dbplyr (development version)
+* The translation of `stringr::str_like()` now defaults to use case-sensitive LIKE when argument `ignore_case` is set as FALSE instead of when this argument is set as TRUE.(@edward-burn, #1488)
 
 # dbplyr 2.5.0
 

R/backend-.R

@@ -280,11 +280,16 @@ base_scalar <- sql_translator(
   str_trim = sql_str_trim,
   str_c = sql_paste(""),
   str_sub = sql_str_sub("SUBSTR"),
+  # https://docs.getdbt.com/sql-reference/like is typically case sensitive
   str_like = function(string, pattern, ignore_case = TRUE) {
     if (isTRUE(ignore_case)) {
-      sql_expr(!!string %LIKE% !!pattern)
+      cli_abort(c(
+        "Backend does not support case insensitve {.fn str_like}.",
+        i = "Set ignore_case = FALSE for case sensitive match.",
+        i = "Or use `tolower()` on both arguments to achieve a case insensitive match."
+      ))
     } else {
-      cli::cli_abort("Backend only supports case insensitve {.fn str_like}.")
+      sql_expr(!!string %LIKE% !!pattern)
     }
   },
 

tests/testthat/_snaps/backend-.md

@@ -42,10 +42,12 @@
 # can translate case insensitive like
 
     Code
-      test_translate_sql(str_like(x, "abc", ignore_case = FALSE))
+      test_translate_sql(str_like(x, "abc", ignore_case = TRUE))
     Condition
       Error in `str_like()`:
-      ! Backend only supports case insensitve `str_like()`.
+      ! Backend does not support case insensitve `str_like()`.
+      i Set ignore_case = FALSE for case sensitive match.
+      i Note, using `tolower()` to cast string and pattern to lower case would also achieve a case insenitive match.
 
 # default raw escapes translated correctly
 

tests/testthat/_snaps/tbl-sql.md

@@ -34,6 +34,6 @@
       The `check_from` argument of `tbl_sql()` is deprecated as of dbplyr 2.5.0.
     Output
       # Source:   table<`x`> [0 x 1]
-      # Database: sqlite 3.45.0 [:memory:]
+      # Database: sqlite 3.45.2 [:memory:]
       # i 1 variable: y <lgl>
 

tests/testthat/test-backend-.R

@@ -101,11 +101,14 @@ test_that("lead and lag translate n to integers", {
 
 # strings -----------------------------------------------------------------
 
-test_that("can translate case insensitive like", {
+test_that("can only translate case sensitive str_like", {
   local_con(simulate_dbi())
-  test_translate_sql(str_like(x, "abc"))
+  expect_equal(test_translate_sql(str_like(x, "abc", ignore_case = FALSE)),
+               sql("`x` LIKE 'abc'"))
+  expect_equal(test_translate_sql(str_like(x, "ABC", ignore_case = FALSE)),
+               sql("`x` LIKE 'ABC'"))
   expect_snapshot(
-    test_translate_sql(str_like(x, "abc", ignore_case = FALSE)),
+    test_translate_sql(str_like(x, "abc", ignore_case = TRUE)),
     error = TRUE
   )
 })