Use dev branch for link to midi-osc-bridge.pd #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the link for this script is broken. Technically it would be good to always link to the latest release version, I guess, but seeing how this pd script isn't really depending much on the inner workings of Tidal I think it's fine to just use
dev. I checked for other links into the Tidal github repo but wasn't sure how to deal with them honestly, because they used different branches and the ones I checked still work.PS: Ah, I think I figured out how the bad link snuck in. It uses
mainfor the trunk branch, whereas other links usemaster, which is the one currently in use by the Tidal repo. I don't know if there ever was a plan to change the branch name.