Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish, rename, and document stepwise functions #1262

Merged
merged 19 commits into from
Feb 2, 2025
Merged

Polish, rename, and document stepwise functions #1262

merged 19 commits into from
Feb 2, 2025

Conversation

yaxu
Copy link
Member

@yaxu yaxu commented Jan 24, 2025

WIP on #1207

@yaxu
Copy link
Member Author

yaxu commented Jan 24, 2025

Can't work out why the expand tests are failing..

@yaxu yaxu added the v1.2 label Jan 24, 2025
@yaxu yaxu marked this pull request as ready for review January 26, 2025 15:42
@yaxu
Copy link
Member Author

yaxu commented Jan 26, 2025

I'll probably add backward compatibility on the names, even though they were 'experimental'..

@yaxu
Copy link
Member Author

yaxu commented Jan 27, 2025

Probably not the final word on this but I might merge it for now?

If/when tidalcycles/Tidal#1111 is solved, I think things will become clearer..

@yaxu
Copy link
Member Author

yaxu commented Feb 2, 2025

Renaming taper to shrink, and adding grow, changing behaviour of negative values to match, so shrink is progressive drop, grow is progressive take. Combine amount and times into single list param, with times defaulting to the tactus.

Making drop drop from the start for positive values and from the end for negative ones.

@yaxu yaxu changed the title Rename stepwise functions Polish, rename, and document stepwise functions Feb 2, 2025
@yaxu yaxu merged commit ce9d230 into main Feb 2, 2025
2 checks passed
@yaxu yaxu deleted the rename-stepwise branch February 2, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant