Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme icons #56

Merged
merged 3 commits into from
Sep 3, 2018
Merged

Use theme icons #56

merged 3 commits into from
Sep 3, 2018

Conversation

mwoehlke
Copy link
Contributor

@mwoehlke mwoehlke commented Aug 25, 2018

Modify UI's to use icons from the system icon theme. (Note: this doesn't remove the resource icons; AFAIK/AFAICT, those will still be used if a theme icon is unavailable.) Also, use QButtonBox where appropriate (which automatically uses appropriate theme icons), and remove some superfluous layouts.

Fixes #13.

Use QDialogButtonBox instead of QPushButton where appropriate. Remove
some superfluous free-standing layouts.
@mwoehlke
Copy link
Contributor Author

These being .ui files, the diffs aren't great, but most should be at least passingly legible at https://github.com/tibirna/qgit/pull/56/files?w=1, even with the layout changes. (Note the ?w=1, which tells github to ignore whitespace-only changes.)

Modify UI's to use icons from the system icon theme.
Add some accelerators to some actions that didn't have them.
@tibirna tibirna merged commit 70de622 into tibirna:master Sep 3, 2018
@mwoehlke mwoehlke deleted the use-theme-icons branch September 3, 2018 15:31
@tibirna tibirna mentioned this pull request Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants