Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider for featured album on homepage #4

Merged
merged 4 commits into from
May 27, 2020
Merged

Slider for featured album on homepage #4

merged 4 commits into from
May 27, 2020

Conversation

Klikini
Copy link

@Klikini Klikini commented May 3, 2020

Provides a new theme setting that takes the name of an album and displays it as a slider at the top of the homepage using lightSlider instead of listing it with the rest of the albums.

Demo

@amcolash
Copy link
Collaborator

amcolash commented May 5, 2020

Very nice looking! I am going to leave @rprieto in charge of approving this one as it is his project. I made the previous theme w/ the exif info, and definitely like this direction.

I suppose I should hack away at some custom css to make my personal gallery look a bit nicer - love the dark twist on yours.

@Klikini
Copy link
Author

Klikini commented May 5, 2020

Just pushed a quick change that works around an issue in lightSlider.

Update: That issue seems nastier than I first thought; several workarounds all failed. I might try finding a different slider library. If you still want to merge this, the worst that happens is that the slider itself doesn't appear (try refreshing the demo a few times), but the thumbnails do (and they still scroll correctly), so it's not horrible. Either way, I understand, and once exams are done, I will try to figure it out.


@amcolash Thanks 😄 I'm coming from Zenphoto, where I always used the default dark theme, so it just made me feel more comfortable to change the color variables here. Now I just need to figure out how to allow linking to individual photos and I'm all set!

@Klikini
Copy link
Author

Klikini commented May 24, 2020

Since this still appears to be an issue with LightSlider and I think it's best to keep using a plugin compatible with LightGallery, I just added some CSS rules to force a constant slider height (defaults to 400px, but can be changed with @slider-height).

If this is still a welcome addition, I think that fixes it (see if you can break my demo, I haven't been able to yet).

@rprieto
Copy link
Member

rprieto commented May 27, 2020

Hi @Klikini, I'm not sure why I'm only seeing your PR now. It's a great feature, thanks for building it!

@rprieto rprieto merged commit 5282835 into thumbsup:master May 27, 2020
@Klikini Klikini deleted the slider branch May 28, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants