feat: add spawn_task and join_task utilities
#789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This is not 100% what I had in mind, but this is definitely a step in the right direction and we can iterate in follow-ups. |
Utilities used to have an error handling approach that follows two rules: + Fail fast: If a panic occurs in a worker thread, the main thread waiting for that worker to complete will also panic, printing the original panic payload. + Forward errors that do not depend on non-mt logic.
gabriele-0201
force-pushed
the
gm_add_task_result
branch
from
88f0f7b to
a480fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilities used to have an error handling approach that follows two rules:
for that worker to complete will also panic, printing the original panic payload.
The utilities do not cover any type of context propagation. I tried many solutions to add context to the panics and error results of the task, but I couldn't find a proper way to provide context for both in a nice way. Open to suggestions!
I decided to push the utilities anyway because with just a few lines of code they achieve the desired goals and simplify the codebase. You will see this in the next PR on this stack.