fix(torture): handle poisoning #778
Open
+263
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the database gets ENOSPC it becomes poisoned and it is required to recreate it in order to perform further changes to the database. this commit does that. To get there, it was necessary to split initing of the agent (happens at most once per agent process) from opening a NOMT instance (can happen multiple times). Note that opening carries the fields such as `bitbox_seed` and `rollback` which might not be useful each time. This is by design, because we might want to test what happens if you do change it from open to open.
This was referenced Feb 3, 2025
Merged
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gabriele-0201
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the database gets ENOSPC it becomes poisoned and it is required to
recreate it in order to perform further changes to the database.
this commit does that.
To get there, it was necessary to split initing of the agent (happens at
most once per agent process) from opening a NOMT instance (can happen
multiple times). Note that opening carries the fields such as
bitbox_seedandrollbackwhich might not be useful each time. Thisis by design, because we might want to test what happens if you do
change it from open to open.