refactor: add bitwise_memcpy #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 18, 2024
pepyakin
reviewed
Nov 18, 2024
nomt/src/beatree/ops/bit_ops.rs
Outdated
Comment on lines
116
to
122
| // Copy `source_bit_len` from the source bytes, starting from the `source_bit_init`ith bit | ||
| // within the first byte into the destination, starting from the `destination_bit_init`ith bit | ||
| // | ||
| // `destination` must be long enough to store the bits, accounting also possible shifts. | ||
| // `source` must have a length multiple of 8 bytes | ||
| // | ||
| // All the bits in `destination` not involved in the copy will be left unchanged. |
There was a problem hiding this comment.
Why not make it a rustdoc?
There was a problem hiding this comment.
No real reason, it's a mistake, it should be a rustdoc yes
gabriele-0201
force-pushed
the
gm_bitwise_memcpy
branch
from
228f671 to
e0eef91
Compare
gabriele-0201
force-pushed
the
gm_quickcheck_tests_add_printlns
branch
from
14c01c5 to
21d5177
Compare
gabriele-0201
force-pushed
the
gm_bitwise_memcpy
branch
from
e0eef91 to
fdd04bb
Compare
gabriele-0201
changed the base branch from
gm_quickcheck_tests_add_printlns
to
master
rphmeier
reviewed
Nov 20, 2024
nomt/src/beatree/ops/bit_ops.rs
Outdated
| destination: &mut [u8], | ||
| destination_bit_init: usize, | ||
| source: &[u8], | ||
| source_bit_init: usize, |
There was a problem hiding this comment.
style: a slice start is usually referred to as "start" not "init". "init" implies that it's a value, not a position.
There was a problem hiding this comment.
Thanks, yes, this makes perfect sense. I generally use them interchangeably, but now that I have a clearer idea, I will use them properly!
rphmeier
approved these changes
Nov 20, 2024
abstract copy and shift bits logic
gabriele-0201
force-pushed
the
gm_bitwise_memcpy
branch
from
fdd04bb to
cfdcca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr not only extracts the shift and copy bits logic a new function(
bitwise_mempcy), but also includes a slight update: nowbitwise_memcpyleaves unchanged all the bits that are not part of the copy in the destinationedit. the pr now also includes a replacement of
initwithstartevery time it was not used correctly