Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: More consistent names shadowPositionWorld, materialAO #1453

Merged
merged 2 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/three/src/Three.TSL.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ export const mat2: typeof TSL.mat2;
export const mat3: typeof TSL.mat3;
export const mat4: typeof TSL.mat4;
export const matcapUV: typeof TSL.matcapUV;
export const materialAOMap: typeof TSL.materialAOMap;
export const materialAO: typeof TSL.materialAO;
export const materialAlphaTest: typeof TSL.materialAlphaTest;
export const materialAnisotropy: typeof TSL.materialAnisotropy;
export const materialAnisotropyVector: typeof TSL.materialAnisotropyVector;
Expand Down Expand Up @@ -410,7 +410,7 @@ export const select: typeof TSL.select;
export const setCurrentStack: typeof TSL.setCurrentStack;
export const shaderStages: typeof TSL.shaderStages;
export const shadow: typeof TSL.shadow;
export const shadowWorldPosition: typeof TSL.shadowWorldPosition;
export const shadowPositionWorld: typeof TSL.shadowPositionWorld;
export const sharedUniformGroup: typeof TSL.sharedUniformGroup;
export const sheen: typeof TSL.sheen;
export const sheenRoughness: typeof TSL.sheenRoughness;
Expand Down
6 changes: 3 additions & 3 deletions types/three/src/nodes/accessors/MaterialNode.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export type MaterialNodeScope =
| typeof MaterialNode.POINT_WIDTH
| typeof MaterialNode.DISPERSION
| typeof MaterialNode.LIGHT_MAP
| typeof MaterialNode.AO_MAP
| typeof MaterialNode.AO
| typeof MaterialNode.REFRACTION_RATIO;

export default class MaterialNode extends Node {
Expand Down Expand Up @@ -80,7 +80,7 @@ export default class MaterialNode extends Node {
static POINT_WIDTH: "pointWidth";
static DISPERSION: "dispersion";
static LIGHT_MAP: "light";
static AO_MAP: "ao";
static AO: "ao";
static REFRACTION_RATIO: "refractionRatio";

scope: MaterialNodeScope;
Expand Down Expand Up @@ -125,5 +125,5 @@ export const materialLineDashOffset: ShaderNodeObject<MaterialNode>;
export const materialPointWidth: ShaderNodeObject<MaterialNode>;
export const materialDispersion: ShaderNodeObject<MaterialNode>;
export const materialLightMap: ShaderNodeObject<MaterialNode>;
export const materialAOMap: ShaderNodeObject<MaterialNode>;
export const materialAO: ShaderNodeObject<MaterialNode>;
export const materialAnisotropyVector: ShaderNodeObject<UniformNode<Vector2>>;
2 changes: 1 addition & 1 deletion types/three/src/nodes/lighting/ShadowBaseNode.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ declare class ShadowBaseNode extends Node {
constructor(light: Light);
}

export const shadowWorldPosition: ShaderNodeObject<Node>;
export const shadowPositionWorld: ShaderNodeObject<Node>;

export default ShadowBaseNode;
Loading