Skip to content

Commit

Permalink
Node: Document more modules. (#1432)
Browse files Browse the repository at this point in the history
* Examples: Fix typos.

* Update three.js

* Add src

* Update patch and delete src

* Update declarations

* Add examples

* Update patch and delete examples
  • Loading branch information
Methuselah96 authored Dec 15, 2024
1 parent 54db79f commit 10cc7d1
Show file tree
Hide file tree
Showing 7 changed files with 309 additions and 185 deletions.
24 changes: 12 additions & 12 deletions examples-testing/changes.patch
Original file line number Diff line number Diff line change
Expand Up @@ -2253,7 +2253,7 @@ index a2f9f379..4ad49d3c 100644
init();

diff --git a/examples-testing/examples/webgl_buffergeometry_instancing.ts b/examples-testing/examples/webgl_buffergeometry_instancing.ts
index a5b90ae6..df382735 100644
index b27f500f..c9432b18 100644
--- a/examples-testing/examples/webgl_buffergeometry_instancing.ts
+++ b/examples-testing/examples/webgl_buffergeometry_instancing.ts
@@ -3,14 +3,14 @@ import * as THREE from 'three';
Expand Down Expand Up @@ -3336,7 +3336,7 @@ index edd158fa..6f58c70a 100644

function animate() {
diff --git a/examples-testing/examples/webgl_custom_attributes_points3.ts b/examples-testing/examples/webgl_custom_attributes_points3.ts
index 1b46a805..e5798e30 100644
index 1bca8ccd..66f12591 100644
--- a/examples-testing/examples/webgl_custom_attributes_points3.ts
+++ b/examples-testing/examples/webgl_custom_attributes_points3.ts
@@ -4,11 +4,11 @@ import Stats from 'three/addons/libs/stats.module.js';
Expand All @@ -3361,7 +3361,7 @@ index 1b46a805..e5798e30 100644
- let boxGeometry1 = new THREE.BoxGeometry(radius, 0.1 * radius, 0.1 * radius, 50, 5, 5);
+ let boxGeometry1: THREE.BufferGeometry = new THREE.BoxGeometry(radius, 0.1 * radius, 0.1 * radius, 50, 5, 5);

// if normal and uv attributes are not removed, mergeVertices() can't consolidate indentical vertices with different normal/uv data
// if normal and uv attributes are not removed, mergeVertices() can't consolidate identical vertices with different normal/uv data

@@ -62,7 +62,7 @@ function init() {
const quaternion = new THREE.Quaternion();
Expand Down Expand Up @@ -3829,7 +3829,7 @@ index 6b013852..382a9b7a 100644
map.needsUpdate = true;
}
diff --git a/examples-testing/examples/webgl_geometry_convex.ts b/examples-testing/examples/webgl_geometry_convex.ts
index ade9cb80..87ea7be3 100644
index 09516c07..fe904221 100644
--- a/examples-testing/examples/webgl_geometry_convex.ts
+++ b/examples-testing/examples/webgl_geometry_convex.ts
@@ -4,7 +4,7 @@ import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
Expand All @@ -3848,7 +3848,7 @@ index ade9cb80..87ea7be3 100644
- let dodecahedronGeometry = new THREE.DodecahedronGeometry(10);
+ let dodecahedronGeometry: THREE.BufferGeometry = new THREE.DodecahedronGeometry(10);

// if normal and uv attributes are not removed, mergeVertices() can't consolidate indentical vertices with different normal/uv data
// if normal and uv attributes are not removed, mergeVertices() can't consolidate identical vertices with different normal/uv data

diff --git a/examples-testing/examples/webgl_geometry_cube.ts b/examples-testing/examples/webgl_geometry_cube.ts
index 572601ac..136a3141 100644
Expand Down Expand Up @@ -5642,7 +5642,7 @@ index b137c550..891e5541 100644
pointer.y = -(event.clientY / window.innerHeight) * 2 + 1;
}
diff --git a/examples-testing/examples/webgl_interactive_points.ts b/examples-testing/examples/webgl_interactive_points.ts
index 93113b86..e090fb6c 100644
index b6be0df0..2bc27dae 100644
--- a/examples-testing/examples/webgl_interactive_points.ts
+++ b/examples-testing/examples/webgl_interactive_points.ts
@@ -4,19 +4,19 @@ import Stats from 'three/addons/libs/stats.module.js';
Expand Down Expand Up @@ -5677,7 +5677,7 @@ index 93113b86..e090fb6c 100644
- let boxGeometry = new THREE.BoxGeometry(200, 200, 200, 16, 16, 16);
+ let boxGeometry: THREE.BufferGeometry = new THREE.BoxGeometry(200, 200, 200, 16, 16, 16);

// if normal and uv attributes are not removed, mergeVertices() can't consolidate indentical vertices with different normal/uv data
// if normal and uv attributes are not removed, mergeVertices() can't consolidate identical vertices with different normal/uv data

@@ -38,8 +38,8 @@ function init() {

Expand Down Expand Up @@ -7191,7 +7191,7 @@ index 45361b92..f5d72d3c 100644
if (geometry) {
const mesh = new THREE.Mesh(geometry, material);
diff --git a/examples-testing/examples/webgl_loader_texture_dds.ts b/examples-testing/examples/webgl_loader_texture_dds.ts
index bc4bd057..0bf94def 100644
index 0a697e1a..6137631b 100644
--- a/examples-testing/examples/webgl_loader_texture_dds.ts
+++ b/examples-testing/examples/webgl_loader_texture_dds.ts
@@ -2,8 +2,8 @@ import * as THREE from 'three';
Expand All @@ -7205,9 +7205,9 @@ index bc4bd057..0bf94def 100644

init();

@@ -106,7 +106,7 @@ function init() {
const material11 = new THREE.MeshBasicMaterial({ map: map9 });
@@ -111,7 +111,7 @@ function init() {
const material12 = new THREE.MeshBasicMaterial({ map: map10 });
const material13 = new THREE.MeshBasicMaterial({ map: map11 });

- let mesh = new THREE.Mesh(new THREE.TorusGeometry(), material1);
+ let mesh: THREE.Mesh = new THREE.Mesh(new THREE.TorusGeometry(), material1);
Expand Down Expand Up @@ -11571,7 +11571,7 @@ index 18020f78..3b61996d 100644
init();
render();
diff --git a/examples-testing/examples/webgl_shadow_contact.ts b/examples-testing/examples/webgl_shadow_contact.ts
index 9eda35b8..0c262569 100644
index f402fa20..8e71282d 100644
--- a/examples-testing/examples/webgl_shadow_contact.ts
+++ b/examples-testing/examples/webgl_shadow_contact.ts
@@ -5,9 +5,9 @@ import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
Expand Down Expand Up @@ -16338,7 +16338,7 @@ index 535e1c93..ab2e4ee0 100644
canvas.width = tileWidth;
context.drawImage(imageObj, tileWidth * i, 0, tileWidth, tileWidth, 0, 0, tileWidth, tileWidth);
diff --git a/examples-testing/examples/webxr_vr_panorama_depth.ts b/examples-testing/examples/webxr_vr_panorama_depth.ts
index 66215469..9ad505c4 100644
index 42ac8332..093dcd93 100644
--- a/examples-testing/examples/webxr_vr_panorama_depth.ts
+++ b/examples-testing/examples/webxr_vr_panorama_depth.ts
@@ -1,12 +1,16 @@
Expand Down
Loading

0 comments on commit 10cc7d1

Please sign in to comment.