Binance: Add order side #1782
Merged
Binance: Add order side #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazbert
requested changes
Jan 21, 2025
|
codespell seems to be erroring in the code that is not related to the PR |
shazbert
approved these changes
Jan 22, 2025
gloriousCode
approved these changes
Jan 22, 2025
| TID: strconv.FormatInt(tradeData[i].ID, 10), | ||
| Exchange: b.Name, | ||
| CurrencyPair: p, | ||
| AssetType: a, | ||
| Price: tradeData[i].Price, | ||
| Amount: tradeData[i].Qty, | ||
| Timestamp: tradeData[i].Time.Time(), | ||
| }) | ||
| } | ||
| if tradeData[i].IsBuyerMaker { // Seller is Taker |
There was a problem hiding this comment.
Makes me wish for c# ? operator
thrasher-
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Currently, the Binance side is marked as unknown. The raw data includes the isBuyerMaker: bool flag, which indicates the initiating side. Based on that, add a side.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist