exchanges: Okx Update #1420
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| package futures | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestStringToContractSettlementType(t *testing.T) { | ||
| t.Parallel() | ||
| contractSettlementTypesMap := map[string]struct { | ||
| CT ContractSettlementType | ||
| Error error | ||
| }{ | ||
| "lInear": {Linear, nil}, | ||
| "LINEAR": {Linear, nil}, | ||
| "Inverse": {Inverse, nil}, | ||
| "unset": {UnsetSettlementType, nil}, | ||
| "hybRiD": {Hybrid, nil}, | ||
| "LinearOrInverse": {LinearOrInverse, nil}, | ||
| "": {UnsetSettlementType, nil}, | ||
| "Quanto": {Quanto, nil}, | ||
| "QUANTO": {Quanto, nil}, | ||
| "Unknown": {UnsetSettlementType, ErrInvalidContractSettlementType}, | ||
| } | ||
| for x, v := range contractSettlementTypesMap { | ||
| val, err := StringToContractSettlementType(x) | ||
| assert.Equal(t, v.CT, val) | ||
| assert.ErrorIs(t, err, v.Error) | ||
| } | ||
| } | ||
|
|
||
| func TestContractSettlementTypeString(t *testing.T) { | ||
| t.Parallel() | ||
| contractSettlementTypeToStringMap := map[ContractSettlementType]string{ | ||
| UnsetSettlementType: "unset", | ||
| Linear: "linear", | ||
| Inverse: "inverse", | ||
| Quanto: "quanto", | ||
| LinearOrInverse: "linearOrInverse", | ||
| Hybrid: "hybrid", | ||
| ContractSettlementType(200): "unknown", | ||
| } | ||
| for k, v := range contractSettlementTypeToStringMap { | ||
| assert.Equal(t, v, k.String()) | ||
| } | ||
| } | ||
|
|
||
| func TestContractTypeToString(t *testing.T) { | ||
| t.Parallel() | ||
| contractTypeToStringMap := map[ContractType]string{ | ||
| Daily: "day", | ||
| Perpetual: "perpetual", | ||
| LongDated: "long_dated", | ||
| Weekly: "weekly", | ||
| Fortnightly: "fortnightly", | ||
| ThreeWeekly: "three-weekly", | ||
| Monthly: "monthly", | ||
| Quarterly: "quarterly", | ||
| SemiAnnually: "semi-annually", | ||
| HalfYearly: "half-yearly", | ||
| NineMonthly: "nine-monthly", | ||
| Yearly: "yearly", | ||
| Unknown: "unknown", | ||
| UnsetContractType: "unset", | ||
| ContractType(200): "unset", | ||
| } | ||
| for k, v := range contractTypeToStringMap { | ||
| assert.Equal(t, v, k.String()) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a config version to add spread to assetTypes for user's config:)
If this is the next PR to be merged, then it can be the next V* on master.
@thrasher- can confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean by for user's config. If it is in the config.json files it is already done.
Correct me if I understood what you mean wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is indeed targeted to be merged as soon as it's ready 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuael I don't see that it's already done.
If I check out your branch, and run it
spreadis not added to the assets listed in pairs.I thought I might be wrong and your call to
SetGlobalPairsManagerinSetDefaultsmight add it.I'm thinking you want something like this which adds an entry for spread on upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbjk I am getting it and I deleted the reference from config just to make sure:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this
I put a hardcoded symbol in because without it the first run won't go smoothly. Can't see a way around that for this kind of asset. If they were all dated then ... Really don't know how we'd make it safe for first run.
ensureOneEnabledthing would need to have new available pairs first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so:
Which is kinda okay, cos the asset isn't enabled.
Think it'd probably interact okay with #1735 as well.
enabledwill be populated, and assetEnabled set to true, and everything is okayThis gives us a weird inconsistency on upgrade.
I'd vote for having a config upgrade to give us a sane available pairs base-state.
Also can choose if you want to enable or disable the asset by default. I'm assuming enable.
Also accepting if we just ignore this, but it feels unnecessarily harsh on upgraders to have different results on subsequent runs.
Also sparing a thought for users who run
-dryin containersThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: No input from anyone else on this.
I think it's still actionable, and I provided an example solution above :)