[DERCBOT-1327] Git hooks - Gitleaks #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assouktim
force-pushed
the
feature/dercbot-1327
branch
from
83a9844 to
aaadd6c
Compare
Benvii
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks for this PR 👍️
Missing :
- Config settings and ragquery exemples here : https://github.com/theopenconversationkit/tock/tree/master/gen-ai/orchestrator-server/src/main/python/tock-llm-indexing-tools/examples
Can you also add to the main README.md how to setup this hook / pre-commit, so that new developers will have the documentation.
gen-ai/orchestrator-server/src/main/python/server/.pre-commit-config.yaml
Show resolved
Hide resolved
Benvii
approved these changes
Jan 14, 2025
Benvii
requested changes
Jan 14, 2025
rkuffer
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git hook to detect secrets such as passwords, API keys and tokens in git repositories.
Breaking change
For deployment using RAW secrets stored in mongo database or calling the Gen AI Orchestrator using raw secret (which is not advised for obvious security reasons), the format of the secret is changed key containing the secret value was previously named api_key.value is now named api_key.secret.
NB : We have not updated the existing data, as we consider that only developers use Raw-type secrets (which are subject to code refactoring)