Make starfall error hook use 'world' for server errors (#1833)

* Make starfall error hook use 'world' for server errors

* Use world instead of false for server errors

lua/entities/starfall_processor/cl_init.lua

@@ -130,7 +130,7 @@ hook.Add("StarfallError", "StarfallErrorReport", function(_, owner, client, main
 	if not IsValid(owner) then return end
 	local local_player = LocalPlayer()
 	if owner == local_player then
-		if not client or client == owner then
+		if client:IsWorld() or client == owner then
 			SF.AddNotify(owner, message, "ERROR", 7, "ERROR1")
 		elseif client then
 			if should_notify then

lua/entities/starfall_processor/shared.lua

@@ -135,7 +135,7 @@ function ENT:Error(err)
 		self:SetColor(Color(255, 0, 0, 255))
 	end
 
-	hook.Run("StarfallError", self, self.owner, CLIENT and LocalPlayer() or false, self.sfdata and self.sfdata.mainfile or "", msg, traceback)
+	hook.Run("StarfallError", self, self.owner, CLIENT and LocalPlayer() or Entity(0), self.sfdata and self.sfdata.mainfile or "", msg, traceback)
 	SF.SendError(self, msg, traceback)
 end
 

lua/starfall/libs_sh/hook.lua

@@ -572,10 +572,10 @@ add("Tick")
 -- @class hook
 -- @shared
 -- @param Entity ent Starfall chip that errored
--- @param Player ply Who's fault it errored. Owner of the chip if on server, or player that the script errored if on client
+-- @param Player|Entity ply Who's fault it errored. World-entity if it was a server error, or player that the script errored if on client
 -- @param string err Error message
 add("StarfallError", nil, function(instance, ent, owner, errply, _, err)
-	return true, {instance.WrapObject(ent), instance.WrapObject(errply or owner), err}
+	return true, {instance.WrapObject(ent), instance.WrapObject(errply), err}
 end)
 
 -- Game Events

lua/starfall/transfer.lua

@@ -251,7 +251,6 @@ else
 			callback = callback - 1
 			if callback>0 then return end
 			if chip and owner and client then
-				if client:IsWorld() then client = nil end
 				hook.Run("StarfallError", chip, owner, client, mainfile, message, traceback, should_notify)
 			end
 		end