Do not run the npm publish action if package version was published #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the tag isn't created, but the version exists on NPM, then it should be fail and require manual intervention. I'm not sure that we want to recover here. Instead, we should manually mitigate and create the tag by hand which will then prevent the workflow from running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The NPM publish step is failing because
@effection-contrib/jsonl-storewas previously published to NPM.Approach
Check if the version was published to NPM in Deno and skip the publish step in GA. It's impossible to use matrix context in job.if, hence I still have to run the job but skip the publish step.