Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIRIND's Tomak79S #2394

Closed
wants to merge 1 commit into from
Closed

Add SIRIND's Tomak79S #2394

wants to merge 1 commit into from

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Dec 19, 2024

Add SIRIND's Tomak79S

Description

This is a solder version PCB for SIRIND's Tomak79 keyboard.
I would appreciate it if you would allow me to merge this into the VIA.

QMK Pull Request

qmk/qmk_firmware#24684

VIA Keymap Pull Request

the-via/qmk_userspace_via#37

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Add Tomak79S
@Cipulot
Copy link
Collaborator

Cipulot commented Dec 22, 2024

@eerraa as of now the PR is blocked and invalid too.

As per the PR you opened for the Keymap, the board didn't used any custom code: the-via/qmk_userspace_via#37

Screenshot 2024-12-22 at 4 49 50 PM

Yet the presented JSON uses elements that leverage the custom UI handling.

Either remove the usage of the custom UI elements from the submitted json in this PR or open another PR in https://github.com/the-via/qmk_userspace_via including the code for the handling for the handling fo the custom UI elements.

@Cipulot Cipulot added invalid This doesn't seem right blocked labels Dec 22, 2024
@eerraa eerraa closed this Dec 23, 2024
@eerraa
Copy link
Contributor Author

eerraa commented Dec 23, 2024

@Cipulot
Thanks for always helping.
I'll try to add Custom UI related code to qmk_userspace_via.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants