Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Binepad BNK8 #2379

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

silvinor
Copy link
Contributor

@silvinor silvinor commented Dec 6, 2024

Description

Add Binepad BNK8

QMK Pull Request

VIA Keymap Pull Request

Checklist

  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@silvinor silvinor marked this pull request as ready for review December 24, 2024 21:07
v3/binepad/bnk8/bnk8.json Outdated Show resolved Hide resolved
@Cipulot
Copy link
Collaborator

Cipulot commented Jan 1, 2025

@silvinor in the waiting room until the PR the-via/qmk_userspace_via#36 adds the code handling for the custom UI elements.
Also, could you pull and apply the suggested formatting? for some reason, I can't force the commit myself.

@Cipulot Cipulot added pending VIA keymap merge Waiting for merge into VIA keymap needs work The PR needs fixes/ things need to be addressed labels Jan 1, 2025
Co-authored-by: Cipulot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed pending VIA keymap merge Waiting for merge into VIA keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants