Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Short Item Descriptions (for chat) #196

Draft
wants to merge 1 commit into
base: release-0.2.2
Choose a base branch
from

Conversation

zithith
Copy link
Collaborator

@zithith zithith commented Jan 2, 2025

Type

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
A clear and concise description of the changes you are making. What does this PR implement or fix?

Related Issue
Closes #141

How Has This Been Tested?
Describe how you tested the changes and how others can replicate the testing steps.

Screenshots (if applicable)
Add screenshots or GIFs that help illustrate the changes, especially if they affect the UI or user-facing aspects of the system.

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • I have tested my changes on Foundry VTT version: [insert version here].

Additional context
Add any other context or information here that would be useful for reviewers.

@zithith zithith self-assigned this Jan 2, 2025
@LLilliputian
Copy link

Hey, sorry realise I should of mentioned on the issue (missed that bit in the contributing guide) but started taking a look/working on this issue a little bit ago. Just wanted to check if you'd be ok with me still continuing on with it?

@zithith
Copy link
Collaborator Author

zithith commented Jan 3, 2025

Hah, yeah!
That's be great, less for me to panic about, though that may change once the team has a chat about release plans and schedules.
Hopefully what I've got there can help as a foundation? Or have I just unwittingly copied a lot of the work you did? 😅
If we don't get some heads up on the issue page itself, we can't see what branches people have on their own forks without actively going for a look!

But thanks for hollering, let me know if you need anything for this

@LLilliputian
Copy link

Thanks, and yeah sorry will remember to post on the issue in the future and will do that now!

Think a fair amount is stuff I've done but I'm new to typescript and haven't done a lot of html and css so think you might have done them better than me so will have another look through and nick some of what you've done 😄

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants