Inline Tabs for Actor sheets - Pop-Out! workaround

[zithith]

Type

• Bug fix
• Feature
• Refactor
• Other (please describe):

Description
Added a setting toggle (as per the item sheet one, but inverted) to make the tabs for actor sheets fall in-line, more like the default foundry behaviour. Required a small re-factor of the navigation parts for the actor sheets so that they appear in a relevant place in the sheet structure.

Related Issue
Closes #194

How Has This Been Tested?
Local machine. Opened sheets with and without the setting toggled to see the change (doesn't re-render already opened sheets).

Screenshots (if applicable)

Checklist:

• I have commented on my code, particularly in hard-to-understand areas.
• My changes do not introduce any new warnings or errors.
• My PR does not contain any copyrighted works that I do not have permission to use.
• I have tested my changes on Foundry VTT version: 12.331.

[zithith]

Note the styling is not great... at all...
A) It's a workaround
B) I didn't want to upset the merge conflicts for mango's styling branches more than I had to.

I did make the decision that I left out the labels on the tabs as there are too many of them for the space on the sheet. Though if people think adding them back for accessibility is better, we could look at stacking icon over text?

[MangoFVTT]

This is a fine change for 0.2.2, but will need to be discarded and rebuilt for 0.3.0 I suspect, since the CSS layout won't translate properly

[MangoFVTT]

I think we should make the setting consistent here where on = vertical and off = horizontal. It doesn't make sense for the 2 settings to do opposite things

[zithith]

I had considered that, but I felt it made more sense to me that the defaults for any optional settings are "off" and that those defaults set it to the way we are suggesting people start.

[zithith]

This is a fine change for 0.2.2, but will need to be discarded and rebuilt for 0.3.0 I suspect, since the CSS layout won't translate properly

Yeah, looking at the handlebars changes for your styling PR as well this seems like it would be almost entirely re-worked. Probably best to just strike it from 0.2.2 so we don't end up reverting functionality, especially as previously mentioned, it doesn't seem to do what people were after (at least according to my testing).