Skip to content

Commit

Permalink
fixup! refactor: Move release description generation logic into separ…
Browse files Browse the repository at this point in the history
…ate file to enable code sharing

The `--description` option of the `release-cli create` command doesn't
support specifying absolute path as the file input, this patch translates
the path into relative path to workaround this limitation.

Refer-to: internal/commands/create.go · d21c6f0f · GitLab.org / release-cli · GitLab <https://gitlab.com/gitlab-org/release-cli/-/blob/d21c6f0f/internal/commands/create.go#L92-120>
Signed-off-by: 阿仁 <[email protected]>
  • Loading branch information
阿仁 committed Nov 1, 2023
1 parent e5991d9 commit 1a81997
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion continuous-integration/create-gitlab-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ fi
release_cli_create_opts=(
--name "${CI_PROJECT_TITLE} ${release_version}"
--tag-name "${CI_COMMIT_TAG}"
--description "${detailed_changes_file}"

# WORKAROUND: Absolute path is not accepted as file input
--description "${detailed_changes_file##*/}"
)

shopt -s nullglob
Expand Down

0 comments on commit 1a81997

Please sign in to comment.