Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gleam]: first attempt to add Gleam. #8016

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

whiplash
Copy link
Contributor

@whiplash whiplash commented Dec 3, 2024

Initial work for #7386

@whiplash whiplash requested a review from waghanza as a code owner December 3, 2024 10:19
@whiplash whiplash mentioned this pull request Dec 3, 2024
@@ -0,0 +1,18 @@
{{#language.image}}
FROM gleamlang/gleam
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a maintained version of a docker image ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to me to be the one. Or maybe we should copy this https://github.com/gleam-lang/example-todomvc/blob/main/Dockerfile

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/gleam-lang/gleam/pkgs/container/gleam it should be

Suggested change
FROM gleamlang/gleam
FROM ghcr.io/gleam-lang/gleam:v1.6.3-elixir

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe

FROM ghcr.io/gleam-lang/gleam:v1.6.3-erlang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish somebody using gleam would give us hints

FROM gleamlang/gleam
{{/language.image}}
{{^language.image}}
FROM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. Sorry.

@@ -0,0 +1,7 @@
framework:
website: https://github.com/rawhat/mist
version: "3.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "3.0.0"
version: 3.0

@@ -0,0 +1,7 @@
framework:
website: https://github.com/rawhat/mist
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
website: https://github.com/rawhat/mist
github: rawhat/mist

gleam/tmist/gleam.toml Outdated Show resolved Hide resolved
@@ -0,0 +1,18 @@
{{#language.image}}
FROM gleamlang/gleam
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe

FROM ghcr.io/gleam-lang/gleam:v1.6.3-erlang

[dependencies]
gleam_stdlib = ">= 0.34.0 and < 2.0.0"
mist = ">= 3.0.0 and < 4.0.0"
gleam_erlang = ">= 0.32.0 and < 1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gleam_stdlib = ">= 0.34.0 and < 2.0.0"
mist = ">= 3.0.0 and < 4.0.0"
gleam_erlang = ">= 0.32.0 and < 1.0.0"
gleam_http = ">= 3.7.1 and < 4.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mist = ">= 3.0.0 and < 4.0.0"
gleam_erlang = ">= 0.32.0 and < 1.0.0"
gleam_http = ">= 3.7.1 and < 4.0.0"
gleam_otp = ">= 0.14.1 and < 1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gleam_otp = ">= 0.14.1 and < 1.0.0"

[dev-dependencies]
gleeunit = ">= 1.0.0 and < 2.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe for testing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could not this be generated onto containers ? I mean using bootstrap config option

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea

Co-authored-by: Marwan Rabbâa <[email protected]>
@waghanza
Copy link
Collaborator

waghanza commented Dec 6, 2024

I suggest to wait until sunday, and merge nomatter what + ping any gleam contributor to make sure this is a correct implementation

@waghanza waghanza merged commit e68e791 into the-benchmarker:master Dec 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants