Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store handwriting #21

Merged
merged 12 commits into from
Jul 19, 2024
Merged

feat: store handwriting #21

merged 12 commits into from
Jul 19, 2024

Conversation

alexanderbira
Copy link
Member

  • Add storing and loading of canvas data (strokes and app state)
    • This is done fully on the frontend by using a JSON string as the answer sent to be stored in the answer table

@Gum-Joe Gum-Joe mentioned this pull request Jul 19, 2024
Merged
Base automatically changed from feat-integrate-handwriting to master July 19, 2024 13:38
@Gum-Joe Gum-Joe force-pushed the feat-store-handwriting branch from 0301b3e to a531ff3 Compare July 19, 2024 14:01
procaconsul
procaconsul requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@procaconsul procaconsul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Higher level remark: I think in the previous PR we missed a suggestion: username in useLiveUpdates (and therefore in Canvas too) is unused, and should be removed.

src/components/questionStructure/Task/variants/HandwritingTask/types.ts Outdated Show resolved Hide resolved
src/components/questionStructure/Task/variants/HandwritingTask/HandwritingEditor.tsx Outdated Show resolved Hide resolved
src/components/questionStructure/Task/variants/HandwritingTask/ViewOnlyCanvas.tsx Outdated Show resolved Hide resolved
src/components/questionStructure/Task/variants/HandwritingTask/types.ts Show resolved Hide resolved
@Gum-Joe
Copy link
Contributor

Gum-Joe commented Jul 19, 2024

Higher level remark: I think in the previous PR we missed a suggestion: username in useLiveUpdates (and therefore in Canvas too) is unused, and should be removed.

This happens in the next MR #22

Gum-Joe and others added 2 commits July 19, 2024 16:14
@procaconsul procaconsul merged commit 3d29a0f into master Jul 19, 2024
4 checks passed
@procaconsul procaconsul deleted the feat-store-handwriting branch July 19, 2024 15:20
@Gum-Joe Gum-Joe restored the feat-store-handwriting branch July 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gum-Joe Gum-Joe Gum-Joe left review comments

@procaconsul procaconsul procaconsul requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexanderbira @Gum-Joe @procaconsul @matalex412 @nick-bolas @IlliaDerevianko