Update prometheus 3.0 rebase #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
update-prometheus-3.0-rebase
branch
from
25f4429 to
1cc718a
Compare
* engine: allow to override opts at query time Signed-off-by: Michael Hoffmann <[email protected]> * engine: add more constructors Signed-off-by: Michael Hoffmann <[email protected]> --------- Signed-off-by: Michael Hoffmann <[email protected]> Co-authored-by: Michael Hoffmann <[email protected]>
For very distributed setups we need to be able to deal with partial failures. This commit adds an option to continue evaulation if we encounter an error in a remote engine but dont want to fail the whole query. Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]>
…#502) LookbackDelta and Stats were unexported fields of the struct. We cannot write to them like this so we need to export them. Signed-off-by: Michael Hoffmann <[email protected]> Co-authored-by: Michael Hoffmann <[email protected]>
…bels away (thanos-io#504) * execution: initialize next in aggregation even if we aggregate the labels away Signed-off-by: Michael Hoffmann <[email protected]> * execute: review on execution/aggregate/hashaggregate.go Co-authored-by: Filip Petkovski <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]> --------- Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]> Co-authored-by: Michael Hoffmann <[email protected]> Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
If coalesce has a single downstream operator, we can skip it and directly return the downstream. Signed-off-by: Filip Petkovski <[email protected]>
* Fix distributed queries with explicit timestamp The distributed optimizer does not consider queries with a specific timestamp which causes them to be incorrect for some cases. Signed-off-by: Filip Petkovski <[email protected]> * Fallback when no match Signed-off-by: Filip Petkovski <[email protected]> * Fix tests Signed-off-by: Filip Petkovski <[email protected]> * Remove leftover Signed-off-by: Filip Petkovski <[email protected]> * Cover subqueries Signed-off-by: Filip Petkovski <[email protected]> * Remove field Signed-off-by: Filip Petkovski <[email protected]> * Add logical tests Signed-off-by: Filip Petkovski <[email protected]> --------- Signed-off-by: Filip Petkovski <[email protected]>
scalar() is not really distributive from our experience. This is because it returns NaN even if the given vector selector doesn't match anything so as a consequence it is impossible to know whether the NaN is expected or not from the PoV of the root querier. Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Michael Hoffmann <[email protected]> Co-authored-by: Michael Hoffmann <[email protected]>
SungJin1212
force-pushed
the
update-prometheus-3.0-rebase
branch
from
1cc718a to
c8f835b
Compare
fpetkovski
approved these changes
Feb 4, 2025
@SungJin1212 linter failure seems related |
Signed-off-by: SungJin1212 <[email protected]>
|
Umm, looks like lint is OOM kill a lot. We should do something to fix that. Doesn't need to be this PR |
yeya24
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get a rebase from the main branch to the
update-prometheus-3.0branch to try applying theupdate-prometheus-3.0branch to the Thanos.