logicalplan: fix edgecase with scalar() in distribution #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalar() is not really distributive from our experience. This is because it returns NaN even if the given vector selector doesn't match anything so as a consequence it is impossible to know whether the NaN is expected or not from the PoV of the root querier. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
fix_scalar_edgecase
branch
from
2822dad to
6786ba8
Compare
SungJin1212
pushed a commit
to SungJin1212/promql-engine
that referenced
this pull request
Feb 3, 2025
scalar() is not really distributive from our experience. This is because it returns NaN even if the given vector selector doesn't match anything so as a consequence it is impossible to know whether the NaN is expected or not from the PoV of the root querier. Signed-off-by: Giedrius Statkevičius <[email protected]>
yeya24
pushed a commit
that referenced
this pull request
Feb 5, 2025
scalar() is not really distributive from our experience. This is because it returns NaN even if the given vector selector doesn't match anything so as a consequence it is impossible to know whether the NaN is expected or not from the PoV of the root querier. Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalar() is not really distributive from our experience. This is because it returns NaN even if the given vector selector doesn't match anything so as a consequence it is impossible to know whether the NaN is expected or not from the PoV of the root querier.