Distribute avg aggregation #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently do not distribute the average aggregation because would be incorrect to calculate an average over averages. However, we could rewrite it as sum / count and distribute those two aggregations independently. Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
distributed-average
branch
from
8d22089 to
686b0d2
Compare
GiedriusS
approved these changes
Nov 23, 2023
Co-authored-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Filip Petkovski <[email protected]>
GiedriusS
approved these changes
Nov 23, 2023
| @@ -129,6 +129,7 @@ var distributiveAggregations = map[parser.ItemType]struct{}{ | |||
| parser.SUM: {}, | |||
| parser.MIN: {}, | |||
| parser.MAX: {}, | |||
| parser.AVG: {}, | |||
There was a problem hiding this comment.
I think this might be harmless, but technically its not true that AVG is distributive right? We work around it by rewriting it to sum/count in a different optimizer so that we never have to see avg in this optimizer if i understand correctly. Adding this here seems like it could be a subtle bug waiting to happen
There was a problem hiding this comment.
I think you are right!
I will try to fix this next week, since we have a separate optimizer that rewrites avg, we should remove it from this list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not distribute the average aggregation because would be incorrect to calculate an average over averages. However, we could rewrite it as sum / count and distribute those two aggregations independently.