Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filepath ToolTip #97

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Filepath ToolTip #97

merged 3 commits into from
Nov 7, 2024

Conversation

zayKenyon
Copy link
Contributor

@zayKenyon zayKenyon commented Oct 24, 2024

EDIT: This PR initially changed the displayed file name to the full path, it pivoted to displaying a tooltip of the file path instead.


Closes #64, might close #59 too.

It doesn't show the file extension, though I would understand a change so that it did. Tested with the Front Matter Title plugin, all works there.

@zayKenyon zayKenyon changed the title feat: Display Full File Paths Display Full File Paths Oct 24, 2024
@tgrosinger
Copy link
Owner

I would prefer to avoid a proliferation of too many settings. I'm also worried showing the full path in the list will look really cluttered, or actually truncate the most important part of the filepath.

I think putting the full file path into a popup tooltip would be a more visually-simple approach, as it would also allow showing the real filepath when using the frontmatter titles too.

@zayKenyon zayKenyon marked this pull request as draft November 4, 2024 20:09
Revert 56052b6 in favour of a tooltip.
@zayKenyon zayKenyon changed the title Display Full File Paths Filepath ToolTip Nov 4, 2024
@zayKenyon
Copy link
Contributor Author

This is the behaviour when using the Frontmatter Titles Plugin.

image

@zayKenyon zayKenyon marked this pull request as ready for review November 4, 2024 23:37
@zayKenyon
Copy link
Contributor Author

zayKenyon commented Nov 4, 2024

This could be extended to include the last_modified date as suggested in #39. Personally I would find that useful. Though I understand that it is not the focus of this PR.

Or instead a last_opened like in #66.

It would need to be considered against #76.

@tgrosinger
Copy link
Owner

Looks great, thank you.

@tgrosinger tgrosinger merged commit 9f9cd39 into tgrosinger:main Nov 7, 2024
1 check passed
@zayKenyon zayKenyon deleted the full-path branch November 7, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display full file path Disambiguate long file names
2 participants