-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove
default
feature from Cargo.toml
In the prev commit, we don't use default features in dependencies by default. But it's not clear for rust-analyzer or other toolchains which are not integrated to our build system. To make it simplify, this change removes all `default` feature set from Cargo.toml in this repository. This express that this project requires an additional way to enable toolchain supports which is not added to our build system. Drawbacks -------- 1. rust-analyzer does not support editor agnostic setting. A developer that do not use vscode would requires additional config. rust-lang/rust-analyzer#11010 2. This requires to commit `.vscode/settings.json`.
- Loading branch information
1 parent
03764f2
commit 3bc41e0
Showing
3 changed files
with
11 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"rust-analyzer.cargo.features": [ | ||
// We want to be able to rollout this application to production at all | ||
// Thus we use _production_ as our default build feature set. | ||
"c_at_e_main/production" | ||
], | ||
"rust-analyzer.cargo.noDefaultFeatures": true, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters