Update to latest TinyGo and Rust #2368
Merged
+133
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuraag Agrawal <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
commented
Jan 21, 2025
| // at /rustc/c396bb3b8a16b1f2762b7c6078dc3e023f6a2493/library/core/src/str/count.rs:135:5 - core::str::count::char_count_general_case::hfffa06842344b9fe | ||
| // at /rustc/c396bb3b8a16b1f2762b7c6078dc3e023f6a2493/library/core/src/str/count.rs:135:5 - core::str::count::do_count_chars::h124622240ac1fb8b | ||
| // at /rustc/c396bb3b8a16b1f2762b7c6078dc3e023f6a2493/library/core/src/str/count.rs:71:21 | ||
| // 0: failed to invoke command default |
There was a problem hiding this comment.
Was confused but AFAICT, this test case / comment was created from a different binary than what we have in the source, so I tried updating it.
https://github.com/tetratelabs/wazero/blob/main/internal/testing/dwarftestdata/testdata/rust/main.rs
mathetake
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2357
-buildmode=c-sharedfor reactors along with.WithStartFunctions("_initialize")wasip1and exports to//go:wasmexportto match Gowasm32-wasip1wasm32-wasip1