Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Added in-memory session store #4

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Added in-memory session store #4

merged 1 commit into from
Feb 12, 2024

Conversation

nacx
Copy link
Member

@nacx nacx commented Feb 12, 2024

Ports the in-memory store used by the OIDC filter.

@nacx nacx requested a review from sergicastro February 12, 2024 12:59
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (d9be6fe) 84.61% compared to head (814ccc5) 83.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   84.61%   83.24%   -1.38%     
==========================================
  Files           5        9       +4     
  Lines         247      370     +123     
==========================================
+ Hits          209      308      +99     
- Misses         34       58      +24     
  Partials        4        4              
Files Coverage Δ
internal/authz/oidc/memory.go 100.00% <100.00%> (ø)
internal/authz/oidc/time.go 100.00% <100.00%> (ø)
internal/logging.go 100.00% <ø> (ø)
internal/authz/mock.go 66.66% <66.66%> (ø)
internal/authz/oidc.go 0.00% <0.00%> (ø)
internal/server/authz.go 70.12% <32.14%> (-11.96%) ⬇️

Copy link
Contributor

@sergicastro sergicastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits


var _ Authz = (*oidcHandler)(nil)

// oidc handler is a mockHandler implementation of the Authz interface that implements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// oidc handler is a mockHandler implementation of the Authz interface that implements
// oidc handler is an implementation of the Authz interface that implements

}
}

// session holds the data of a session stored int he in-memory cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// session holds the data of a session stored int he in-memory cache
// session holds the data of a session stored in the in-memory cache

@nacx nacx merged commit 871d5a8 into main Feb 12, 2024
7 of 8 checks passed
@nacx nacx deleted the mem-session-store branch February 12, 2024 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants