This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Add test suite to run e2e tests against the current and legacy authservice #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 90.82% 90.84% +0.01%
==========================================
Files 17 17
Lines 1221 1223 +2
==========================================
+ Hits 1109 1111 +2
Misses 78 78
Partials 34 34
|
sergicastro
approved these changes
Feb 21, 2024
| KEYCLOAK_ADMIN: admin | ||
| KEYCLOAK_ADMIN_PASSWORD: admin | ||
| ports: | ||
| - "8080:8080" |
There was a problem hiding this comment.
is it necessary?
Suggested change
| - "8080:8080" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Adds a test suite that runs against a given authservice image, that can be set as an env var when running the tests. It also adds a matrix build in CI to run such a suite.
To try it out locally:
The legacy image used by default is
ghcr.io/istio-ecosystem/authservice/authservice:0.5.3, but can be customized by setting the env varE2E_LEGACY_IMAGE.