Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Add a test implementation of telemetry.Logger #22

Closed
wants to merge 1 commit into from

Conversation

sergicastro
Copy link
Contributor

so the test expectations can be more specifics in those cases where the returned response is exactly the same.

so the test expectations can be more specifics in those cases where the
returned response is exactly the same.
@sergicastro sergicastro requested a review from nacx February 19, 2024 16:53
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f281f16) 89.39% compared to head (22ed6f2) 89.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files          16       16           
  Lines        1103     1103           
=======================================
  Hits          986      986           
  Misses         84       84           
  Partials       33       33           

@sergicastro
Copy link
Contributor Author

Closing this in favor of using some metric lib to rely on, instead of logs.

@sergicastro sergicastro deleted the logger-for-tests branch February 21, 2024 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant