This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Add OIDC e2e tests based on Keycloak #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 89.39% 89.34% -0.05%
==========================================
Files 16 17 +1
Lines 1103 1117 +14
==========================================
+ Hits 986 998 +12
- Misses 84 85 +1
- Partials 33 34 +1
|
nacx
force-pushed
the
keycloak
branch
8 times, most recently
from
aab78af to
303a974
Compare
nacx
force-pushed
the
keycloak
branch
3 times, most recently
from
7b3c766 to
f019ea6
Compare
sergicastro
reviewed
Feb 20, 2024
| // getCookieName returns the cookie name to use for the session id. | ||
| func getCookieName(config *oidcv1.OIDCConfig) string { | ||
| // GetCookieName returns the cookie name to use for the session id. | ||
| func GetCookieName(config *oidcv1.OIDCConfig) string { |
There was a problem hiding this comment.
why did you export it? I don't find the use.
There was a problem hiding this comment.
I use it in the tests to avoid copying the name logic there.
sergicastro
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.