Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Added token response persistence in the Redis store #12

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Added token response persistence in the Redis store #12

merged 7 commits into from
Feb 15, 2024

Conversation

nacx
Copy link
Member

@nacx nacx commented Feb 14, 2024

No description provided.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (9d0e3d3) 93.88% compared to head (14743c0) 93.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   93.88%   93.25%   -0.63%     
==========================================
  Files          11       13       +2     
  Lines         523      519       -4     
==========================================
- Hits          491      484       -7     
+ Misses         28       20       -8     
- Partials        4       15      +11     
Files Coverage Δ
internal/config.go 100.00% <100.00%> (ø)
internal/oidc/memory.go 100.00% <100.00%> (ø)
internal/oidc/session.go 100.00% <100.00%> (ø)
internal/oidc/token.go 100.00% <100.00%> (ø)
internal/server/logging.go 82.35% <100.00%> (-3.37%) ⬇️
internal/oidc/redis.go 72.61% <72.61%> (ø)

... and 7 files with indirect coverage changes

@nacx nacx requested a review from sergicastro February 14, 2024 16:03
@nacx nacx enabled auto-merge (squash) February 14, 2024 17:03
@$(MAKE) -C e2e $(@)

.PHONY: force-e2e
force-e2e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is to force execution of the e2e/redis or e2e/mock when invoked from the root. You can't set a phony target on patterns (you can't do .PHONY: e2e/%) and since the e2e/mock and e2e/redis folder exists, make simply says everything is up to date.
This target is a PHONY target that is used as a dependency of the e2e/% to force execution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uoo! I see, nice trick!

@nacx nacx merged commit 1e9ecdf into main Feb 15, 2024
7 of 8 checks passed
@nacx nacx deleted the redis branch February 15, 2024 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants