Properly validate configuration

tetrateio · Feb 9, 2024 · 91ba58c · 91ba58c
1 parent 6844fc0
commit 91ba58c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -102,7 +102,7 @@ config/lint:  ## Lint the Config Proto generated code
 test:  ## Run all the tests
 	@go test $(TEST_OPTS) $(TEST_PKGS)
 
-COVERAGE_OPTS     ?=
+COVERAGE_OPTS ?=
 .PHONY: coverage
 coverage:  ## Creates coverage report for all projects
 	@echo "Running test coverage"

diff --git a/internal/config.go b/internal/config.go
@@ -57,5 +57,12 @@ func (l *LocalConfigFile) Validate() error {
 		return err
 	}
 
-	return protojson.Unmarshal(content, &l.Config)
+	if err = protojson.Unmarshal(content, &l.Config); err != nil {
+		return err
+	}
+
+	// Set reasonable defaults for non-supported values
+	l.Config.Threads = 1
+
+	return l.Config.Validate()
 }
diff --git a/internal/testdata/mock.json b/internal/testdata/mock.json
@@ -1,4 +1,6 @@
 {
+  "listen_address":  "0.0.0.0",
+  "listen_port": 8080,
   "log_level": "debug",
   "chains": [
     {